Skip to content

Add visits today sensor for pets #147459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add visits today sensor for pets #147459

wants to merge 2 commits into from
+64 −2

Conversation

natekspencer
Copy link
Contributor

@natekspencer natekspencer commented Jun 24, 2025 •
edited
Loading

Breaking change

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (litterrobot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of litterrobot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign litterrobot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@natekspencer natekspencer mentioned this pull request Jun 24, 2025
Open
8 tasks
joostlek
joostlek requested changes Jun 25, 2025
View reviewed changes
homeassistant/components/litterrobot/sensor.py
key="visits_today",
translation_key="visits_today",
entity_category=EntityCategory.DIAGNOSTIC,
state_class=SensorStateClass.TOTAL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this total increasing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this and ultimately decided on total with last reset due to the scenario of a cat using the litterbox at midnight (or just after, but before the coordinator updates). If the cat had only used the litterbox once the day before, then total increasing would not see an additional visit.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 25, 2025 07:35
@natekspencer natekspencer marked this pull request as ready for review July 1, 2025 16:54
@home-assistant home-assistant bot requested a review from joostlek July 1, 2025 16:54
abmantis
abmantis reviewed Jul 1, 2025
View reviewed changes
homeassistant/components/litterrobot/sensor.py
RobotSensorEntityDescription[Pet](
key="visits_today",
translation_key="visits_today",
entity_category=EntityCategory.DIAGNOSTIC,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why DIAGNOSTIC? Since it is not info about the litter robot, I am not sure if it should be in the diagnostic category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmantis abmantis abmantis left review comments

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: litterrobot new-feature Quality Scale: bronze small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natekspencer @abmantis @joostlek