Skip to content

Add enum sensor for Sonos Power Source #147449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 25, 2025
Merged

Add enum sensor for Sonos Power Source #147449

merged 12 commits into from
Jun 25, 2025

Conversation

PeteRager
Copy link
Contributor

Proposed change

Add sensor to report the current power source for a Sonos portable speaker.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@PeteRager PeteRager requested a review from jjlawren as a code owner June 24, 2025 18:21
@home-assistant
Copy link

Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sonos can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sonos Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@PeteRager PeteRager marked this pull request as draft June 24, 2025 18:22
@PeteRager PeteRager mentioned this pull request Jun 24, 2025
Open
19 tasks
@PeteRager PeteRager marked this pull request as ready for review June 25, 2025 13:14
joostlek
joostlek reviewed Jun 25, 2025
View reviewed changes
@joostlek
Copy link
Member

Should we disable by default?

@abmantis abmantis marked this pull request as draft June 25, 2025 18:15
@PeteRager
Copy link
Contributor Author

Should we disable by default?

Yes, done

joostlek
joostlek reviewed Jun 25, 2025
View reviewed changes
@PeteRager PeteRager marked this pull request as ready for review June 25, 2025 21:39
@joostlek joostlek merged commit 345ec97 into home-assistant:dev Jun 25, 2025
34 checks passed
pelicarno pushed a commit to OlarmTech/home-assistant-core that referenced this pull request Jun 26, 2025
@PeteRager @joostlek @pelicarno
Add enum sensor for Sonos Power Source (home-assistant#147449)
7e639d3 
* feat: add power source sensor

* fix: translations

* fix:cleanup

* fix: simpify

* fix: improve coverage

* fix: improve coverage

* fix: add missing test

* fix: call it charging_base

* fix: disable entity by default

* update snapshots

* Update homeassistant/components/sonos/strings.json

Co-authored-by: Joost Lekkerkerker <[email protected]>

* fix: update test

---------

Co-authored-by: Joost Lekkerkerker <[email protected]>
@PeteRager PeteRager deleted the sonos-power-source branch June 26, 2025 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@jjlawren jjlawren Awaiting requested review from jjlawren jjlawren is a code owner

Assignees

@jjlawren jjlawren

Labels
by-code-owner cla-signed has-tests integration: sonos new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeteRager @joostlek @jjlawren