Update motion_blinds DualShade devices to account for reversed tilt direction #147407
Conversation
Update motion_blinds DualShade devices to account for reversed tilt direction
There was a problem hiding this comment.
Hi @RyanMorash
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| BlindType.RollerTiltMotor: CoverDeviceClass.BLIND, | ||
| } | ||
|
|
||
| DUAL_SHADE_DEVICE_MAP = { |
There was a problem hiding this comment.
Whats the diffrence between the "Tilt devices" and the "Dual shade devices", why would the direction only be changed for some of them?
Why not change the direction of the tilt only devices?
There was a problem hiding this comment.
If it is decided the direction should be changed, we should do it consistantly across all blinds.
There was a problem hiding this comment.
I was assuming that the tilt issue was limited to the DualShade device type. That's the only one I have to test with. If other devices behave similarly then there's no need to break it out.
|
To me its very difficult to judge if the rotation direction is correct or not. I would like a second opinion to judge if we should change or not. |
Breaking change
Any automations that account for the reversed tilt direction of DualShade devices will need to be adjusted.
Proposed change
DualShade devices in the
motion_blindsintegration currently have their tilt direction reversed. This pull request accounts for the difference between the Home Assistant entity model and the Motionblinds implementation. The most important changes include adding a new mapping for DualShade devices and implementing a newMotionDualShadeDeviceclass with reversed tilt direction functionality.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: