Skip to content

Add container arch to system info #147372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2025
Merged

Add container arch to system info #147372

merged 7 commits into from
Jun 24, 2025

Conversation

agners
Copy link
Member

@agners agners commented Jun 23, 2025

Breaking change

Proposed change

This is a follow-up for #146537 and #146561. It removed aiofiles from the core requirements as suggested in #146561 (comment). It also makes the detected architecture available through system info. The container architecture can be different from the reported CPU architecture in cases where the underlying OS is capable of running other architectures (typically x86 on x86_64 or armv7 on aarch64 operating systems).

For Supervisor based installations it also uses the architecture already available from Supervisor. This makes the information more coherent and avoids unnecessary code duplication.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@agners agners requested a review from a team as a code owner June 23, 2025 15:51
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

joostlek
joostlek requested changes Jun 23, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft June 23, 2025 18:52
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@agners
Copy link
Member Author

agners commented Jun 23, 2025

Tests are failing, can you take a look?

Hm, that was harder than I thought, and it actually highlighted a bug I was seeing here too: On a Supervised installation which also has a deprecated arch, not only the hassio deprecation gets created, but also the homeassistant deprecation gets created. The reason is that async_get_system_info() returns the Container installation method, because at that time the hassio integration is not setup yet, so the installation method is not detected correctly 😢

So this lead to the tests failing due to too many issues, since the homeassistant integration creates an issue too.

I've come up with a solution which delays the deprecation issue creation until Home Assistant is up and running. This correctly returns the installation method for Supervisor based installations when the deprecation issue is created in the homeassistant integration.

@agners agners marked this pull request as ready for review June 23, 2025 22:09
@home-assistant home-assistant bot requested a review from joostlek June 23, 2025 22:09
agners added 6 commits June 24, 2025 00:26
@agners
Load container architecture in system info
83aeb57 
Make the Alpine Linux container architecture from the Alpine package
manager available in the system info. This information is useful not
only to create the deprecation repairs, but also as a general
system information since the container architecture may differ from
the host architecture, for example, when running a 64-bit host with
a 32-bit container.
@agners
Use Supervisor arch to determine container arch
f2f98eb 
For installations with Supervisor, use the architecture from the
Supervisor API instead of reading the architecture from the
container. This is more coherent as we trust the Supervisor data
already, and gets rid of an unnecessary dependency for aiofiles.
@agners
Revert "Add aiofiles to pyproject.toml (#146561)"
d6daeb0 
This reverts commit fb4c77d.

aiofiles is no longer needed by the homeassistant integration.
@agners
Fix cloud test
36284c0
@agners
Drop unnecessary pytest parameter
2f736a5
@agners
Delay deprecation checks until Home Assistant is fully initialized
1415d6c 
This aims to delay the async_get_system_info() call until the hassio
integration is fully initialized, to make sure the installation method
is determined correctly.
@agners agners force-pushed the add-container-arch-to-system-info branch from 64fc41f to 1415d6c Compare June 23, 2025 22:26
@frenck frenck merged commit e5d19ba into dev Jun 24, 2025
48 checks passed
@frenck frenck deleted the add-container-arch-to-system-info branch June 24, 2025 07:52
This was referenced Jun 24, 2025
Merged
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality core has-tests integration: hassio integration: homeassistant Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agners @joostlek @frenck