Skip to content

Remove deprecated proxy params from Telegram bot integration #147288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

hanwg
Copy link
Contributor

@hanwg hanwg commented Jun 22, 2025

Proposed change

Proxy params were previously used for proxy authentication.
The params are now part of the proxy_url which can be specified via config flow.
The deprecation was done in 2024 and this change is to remove the unused params for better code maintainability.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@hanwg hanwg marked this pull request as ready for review June 22, 2025 02:50
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hanwg 👍

../Frenck

@frenck frenck merged commit 160163b into home-assistant:dev Jun 24, 2025
34 checks passed
@@ -924,10 +924,6 @@
"proxy_params_auth_deprecation": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the proxy_params_auth_deprecation string since the code for it was removed here.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
@epenet
Copy link
Contributor

epenet commented Jun 26, 2025

@hanwg based on all the changes you made recentely, I highly recommend that you add yourself as a code-owner:

@home-assistant home-assistant unlocked this conversation Jun 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants