-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Convert Ollama to subentries #147286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Ollama to subentries #147286
Conversation
Hey there @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Converting to draft until we have sign off on the Google one. |
Marked as draft until we adopt the "single entry to rule them all" approach coming to Google subentries PR |
1e18148
to
62ac530
Compare
DOMAIN = "ollama" | ||
type OllamaConfigEntry = ConfigEntry[ollama.AsyncClient] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we move this to __init__.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also used in the platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI had added it to __init__
and I had manually moved it to const
🙈
Breaking change
Proposed change
Convert Ollama to use config subentries
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: