Add fields and multiple support to object selector #147215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
19 tasks
| } | ||
| }, | ||
| vol.Optional("multiple", default=False): bool, | ||
| vol.Optional("label_field"): str, |
There was a problem hiding this comment.
Feels like we might miss some checks? Or is the respective optional field here really optional even when another one has been set?
There was a problem hiding this comment.
You can define fields and the first field will be used as label if this one it not defined.
Co-authored-by: G Johansson <[email protected]>
balloob
approved these changes
Jun 21, 2025
abmantis
reviewed
Jun 23, 2025
| str: { | ||
| vol.Required("selector"): dict, | ||
| vol.Optional("required"): bool, | ||
| vol.Optional("label"): str, |
There was a problem hiding this comment.
Should we drop label since we have translation_key already? or do we need to support both?
There was a problem hiding this comment.
Label is here because blueprints can not use translation key.
abmantis
approved these changes
Jun 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Backend support for new options in object selector.
It will first be used to improve the
answerseditor (#147219)Type of change
Additional information
fieldsandmultiplesupport to object selector frontend#25843Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: