Skip to content

Add Google Weather sensors #147141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented Jun 19, 2025

Breaking change

Proposed change

Add sensors to the Google Weather integration.
Depends on #147015
If you review this before that is merged, review only the files added in 6cd7a5c

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 19, 2025 13:31
@tronikos tronikos marked this pull request as ready for review June 19, 2025 13:37
@home-assistant home-assistant bot dismissed their stale review June 19, 2025 13:37

Stale

@tronikos tronikos mentioned this pull request Jun 22, 2025
19 tasks
@joostlek
Copy link
Member

IMO let's close this one for now. When a general contributor opens a PR for a new integration we also wouldn't allow dependent PRs, so let's be consistent :)

@tronikos
Copy link
Member Author

IMO let's close this one for now. When a general contributor opens a PR for a new integration we also wouldn't allow dependent PRs, so let's be consistent :)

I mostly wanted to save time so that I can address any comments you might have in sensor.py (the new changes are mostly limited there). If there is any chance this integration makes it in next release I wanted to have both platforms. I'll mark this as draft but feel free to review sensor.py in the meantime if you have time.

@tronikos tronikos marked this pull request as draft June 22, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants