Skip to content

Add EZVIZ battery camera power status and online status sensor #146822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Add EZVIZ battery camera power status and online status sensor #146822

wants to merge 12 commits into from
+44 −9

Conversation

kizovinh
Copy link

Adding power status and online status sensor for battery camera

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@kizovinh
Adding power status and online status sensor for battery camera
1e93a2d 
Adding power status and online status sensor for battery camera
home-assistant[bot]
home-assistant bot previously requested changes Jun 14, 2025
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kizovinh

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft June 14, 2025 13:15
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @RenierM26, mind taking a look at this pull request as it has been labeled with an integration (ezviz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ezviz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ezviz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@kizovinh kizovinh marked this pull request as ready for review June 14, 2025 13:17
@home-assistant home-assistant bot dismissed their stale review June 14, 2025 13:17

Stale

@kizovinh kizovinh marked this pull request as draft June 14, 2025 15:22
@kizovinh kizovinh marked this pull request as ready for review June 14, 2025 15:23
@kizovinh kizovinh marked this pull request as draft June 17, 2025 08:40
@kizovinh kizovinh marked this pull request as draft June 17, 2025 08:40
@kizovinh kizovinh marked this pull request as ready for review June 17, 2025 08:41
@kizovinh
Copy link
Author

kizovinh commented Jun 18, 2025 •
edited
Loading

Hello @erwindouna @RenierM26, would you please add this feature, I have a battery ezviz camera and I need these sensor for my automation.

@TheJulianJES TheJulianJES changed the title Adding power status and online status sensor for battery camera Add EZVIZ battery camera power status and online status sensor Jun 24, 2025
joostlek
joostlek requested changes Jun 25, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff and pylint are failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft June 25, 2025 13:42
@kizovinh kizovinh requested a review from joostlek June 27, 2025 03:56
@kizovinh
Update sensor.py
283f605 
update ruff/pylint failing
@kizovinh kizovinh marked this pull request as ready for review June 27, 2025 04:16
@frenck frenck requested a review from Copilot June 27, 2025 07:12
Copilot
Copilot AI reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new battery camera sensors (power status and online status) and a record mode sensor to the EZVIZ integration.

  • Extended SENSOR_TYPES with Record_Mode, battery_camera_work_mode, powerStatus, and OnlineStatus
  • Modified async_setup_entry to collect and register optional sensors and record mode
  • Changed async_add_entities to handle a combined entity list
Comments suppressed due to low confidence (1)

homeassistant/components/ezviz/sensor.py:109

  • The new logic for adding optional sensors and Record_Mode is not covered by existing tests. Please add tests to verify that powerStatus, OnlineStatus, and Record_Mode sensors are correctly created when present in coordinator.data.
    entities += [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed integration: ezviz new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kizovinh @joostlek