Skip to content

Add more binary sensors to Alexa Devices #146402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2025

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Jun 9, 2025

Breaking change

Proposed change

Add more binary sensors to Amazon Devices

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 changed the title Add more binary sensors to Amazon Devices Add more binary sensors to Alexa Devices Jun 12, 2025
@chemelli74 chemelli74 force-pushed the chemelli74-amazon-sensors branch from c34513d to c78f46c Compare June 17, 2025 11:19
@chemelli74 chemelli74 marked this pull request as ready for review June 17, 2025 13:21
@chemelli74 chemelli74 requested a review from joostlek June 22, 2025 22:20
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add more test fixtures for this?

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 23, 2025 18:54
@chemelli74 chemelli74 marked this pull request as ready for review June 24, 2025 07:03
@home-assistant home-assistant bot requested a review from joostlek June 24, 2025 07:03
@chemelli74 chemelli74 added this to the 2025.7.0b0 milestone Jun 24, 2025
@joostlek joostlek merged commit f800248 into home-assistant:dev Jun 25, 2025
34 checks passed
@chemelli74 chemelli74 deleted the chemelli74-amazon-sensors branch June 25, 2025 07:50
@chemelli74
Copy link
Contributor Author

Thx!

@frenck frenck removed this from the 2025.7.0b0 milestone Jun 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants