Linkplay - when grouped, the first media player returned is the coordinator #146295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inator Aligns with how other integrations are done (sonos, bluesound, heos...)
|
Hey there @Velleman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
silamon
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
It took me a while to figure out why the leader wasn't on first position in the original code, but I see now. Thank you for taking the time to get this cleaned up.
Please note, a maintainer will run the CI flow soonish, and it will fail on linting. You may want to fix that in the meantime.
joostlek
requested changes
Jun 8, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
requested changes
Jun 9, 2025
silamon
approved these changes
Jun 13, 2025
|
Hey @joostlek let me know if there's anything more i can do to help get this merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Expose a new
is_masterattribute on each LinkPlaymedia_playerentity.Why
Multi-room control cards (e.g. Mini Media Player and the core media-control card) need to know which player is the leader of a LinkPlay group.
The unofficial HACS LinkPlay integration always returned the leader as the first part of the array of the
group_membersattribute, It also seems in line with how Sonos, bluesound_group (see design notes are implementing this attribute.How
By ensuring that the leader is returned first within the array of group_members
Result
The leader is the first of the array returned, when a player is grouped.
No API or configuration changes are required; Home Assistant automatically publishes the new attribute after the next reload of the integration.
Note: I initially started by implementing an
is_masterflag due to my memory of it existing with the previous non official linkplay integration (see closed PR #146286). Upon further testing, this flag wasn't enough to be recognized as the master with integrations such as mini-media-player - it was awaiting the leader to be returned at position [0] of the array. Upon further research this was confirmed to be the case for other media_players such as sonos, bluesound and heos, which seem to have been even further reinforced upon the unification of the attributes into the currentgroup_members).Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: