Add evaporative humidifier for switchbot integration #146235

zerzhang · 2025-06-06T03:00:18Z

Breaking change

Proposed change

Add evaporative humidifier

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2025-06-06T03:00:27Z

Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign switchbot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/switchbot/strings.json

zerzhang · 2025-06-17T02:27:46Z

@joostlek could you help to review this pr?

joostlek · 2025-06-17T08:31:26Z

homeassistant/components/switchbot/humidifier.py

+    async def async_set_humidity(self, humidity: int) -> None:
+        """Set new target humidity."""
+        _LOGGER.debug("Setting target humidity to: %s %s", humidity, self._address)
+        self._last_run_success = bool(await self._device.set_target_humidity(humidity))


I think this is more a general comment, but currently we set _last_run_success and I think instead we should raise a translated exception if the integration did not do what we expect it to do

This has been implemented, I have raised the exception in pyswitchbot

But if it fails, it doesn't set the last update success anymore right? I think this is something we can deprecate and remove from all switchbot entities

joostlek · 2025-06-17T08:31:46Z

homeassistant/components/switchbot/sensor.py

+    "water_level": SensorEntityDescription(
+        key="water_level",
+        translation_key="water_level",
+        icon="mdi:water-check",


use icon translations for this one

home-assistant · 2025-06-17T08:32:13Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

joostlek · 2025-06-23T13:16:52Z

homeassistant/components/switchbot/sensor.py

+    @property
+    def icon(self) -> str | None:
+        """Return the icon based on the sensor's state."""
+
+        if self.entity_description.key != "water_level":
+            return super().icon
+        icons = {
+            "empty": "mdi:water-off",
+            "low": "mdi:water-outline",
+            "medium": "mdi:water",
+            "high": "mdi:water-check",
+        }
+        return icons.get(str(self.native_value), "mdi:water-alert")


use icon translations instead

I have fixed this

joostlek · 2025-06-23T13:17:05Z

homeassistant/components/switchbot/strings.json

+        "state_attributes": {
+          "last_run_success": {
+            "state": {
+              "true": "[%key:component::binary_sensor::entity_component::problem::state::off%]",
+              "false": "[%key:component::binary_sensor::entity_component::problem::state::on%]"
+            }
+          },


these arent used anymore right

these arent used anymore right

i have removed from this pr, but others not, I will remove all of these in a Independent PR

note: we need to deprecate them, so I would suggest to add a comment to the places where we set it, and then just set the variable like we did before, write state, and then raise. That PR would be marked as deprecation and we should explain in the breaking changes section what is changing

For the newly added products, we deprecate the last_run_success attribute. For the already supported products, I will remove this attribute and make a breaking statement. right?

Newly added products won't get it at all, while we need to deprecate it for existing devices and announce it first and then remove in 6 months

But we should still remove it here right

But we should still remove it here right

I have removed it now and i have create a PR #147473 to remove for other products

NoRi2909 · 2025-06-23T14:06:39Z

homeassistant/components/switchbot/strings.json

+      "water_level": {
+        "name": "Water level",
+        "state": {
+          "empty": "Empty",


@joostlek If we merged #146646 before this one we could change this to "[%key:common::state::empty%]".

zerzhang requested a review from Danielhiversen as a code owner June 6, 2025 03:00

home-assistant bot added cla-signed code-quality has-tests integration: switchbot new-feature labels Jun 6, 2025

home-assistant bot assigned Danielhiversen Jun 6, 2025

home-assistant bot added by-code-owner Quality Scale: gold labels Jun 6, 2025

zerzhang force-pushed the feature/add_evaporative_humidifier branch from c155a2e to 1731b68 Compare June 6, 2025 10:33

NoRi2909 reviewed Jun 6, 2025

View reviewed changes

homeassistant/components/switchbot/strings.json Outdated Show resolved Hide resolved

zerzhang force-pushed the feature/add_evaporative_humidifier branch from 64e13b0 to 444c7ae Compare June 11, 2025 06:48

joostlek reviewed Jun 17, 2025

View reviewed changes

joostlek requested changes Jun 17, 2025

View reviewed changes

home-assistant bot marked this pull request as draft June 17, 2025 08:32

zerzhang added 6 commits June 18, 2025 17:09

add support for evaporative humidifier

5d9be9c

add evaporative humidifier unit test

50923a8

clear the humidifier action in pyswitchbot

5821424

fix ruff

43e6b1b

fix Sentence-casing issue

0ba0129

add icon translation

f86c4e9

zerzhang force-pushed the feature/add_evaporative_humidifier branch from 444c7ae to f86c4e9 Compare June 18, 2025 09:11

zerzhang marked this pull request as ready for review June 18, 2025 09:21

home-assistant bot requested a review from joostlek June 18, 2025 09:21

remove last run success

7d4e8a1

joostlek requested changes Jun 23, 2025

View reviewed changes

home-assistant bot marked this pull request as draft June 23, 2025 13:17

use icon translations for water level

d4a3a19

zerzhang marked this pull request as ready for review June 23, 2025 14:02

home-assistant bot requested a review from joostlek June 23, 2025 14:02

NoRi2909 reviewed Jun 23, 2025

View reviewed changes

remove the translation for last run success

94cba99

joostlek approved these changes Jun 25, 2025

View reviewed changes

joostlek merged commit d0b2d1d into home-assistant:dev Jun 25, 2025
34 checks passed

github-actions bot locked and limited conversation to collaborators Jun 26, 2025

Uh oh!

Add evaporative humidifier for switchbot integration #146235

Add evaporative humidifier for switchbot integration #146235

Uh oh!

Conversation

zerzhang commented Jun 6, 2025

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot commented Jun 6, 2025

Uh oh!

Uh oh!

zerzhang commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

home-assistant bot commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!