Skip to content

Add switchbot relayswitch 2PM and garge door opener #146140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Add switchbot relayswitch 2PM and garge door opener #146140

wants to merge 6 commits into from

Conversation

zerzhang
Copy link
Contributor

@zerzhang zerzhang commented Jun 4, 2025 •
edited
Loading

Breaking change

Proposed change

  • Add relayswitch 2pm
  • Add garge door opener

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # SwitchBot Relay Switch 2PM #142358
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zerzhang zerzhang requested a review from Danielhiversen as a code owner June 4, 2025 08:26
@home-assistant
Copy link

home-assistant bot commented Jun 4, 2025

Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet marked this pull request as draft June 4, 2025 08:30
@epenet
Copy link
Contributor

epenet commented Jun 4, 2025

Marked as draft until #146133 is merged and this is rebased

@zerzhang zerzhang mentioned this pull request Jun 5, 2025
Merged
19 tasks
@zerzhang zerzhang force-pushed the feature/add_garage_door_opener_and_2pm branch from 514815a to 62fb951 Compare June 6, 2025 02:38
@zerzhang zerzhang marked this pull request as ready for review June 6, 2025 02:47
@zerzhang zerzhang force-pushed the feature/add_garage_door_opener_and_2pm branch from 02cbc22 to a23ac4b Compare June 6, 2025 10:32
@zerzhang
Copy link
Contributor Author

@joostlek could you help to review this pr?

joostlek
joostlek requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split the 2PM and the garage door opener since the 2PM is a bit more advanced

homeassistant/components/switchbot/entity.py
Comment on lines +65 to +66
if isinstance(self.coordinator.device, switchbot.SwitchbotRelaySwitch2PM):
return self.coordinator.device.get_parsed_data(self._channel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate on what channels are?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate on what channels are?

SwitchbotRelaySwitch2PM has two independent switches, which can count their voltage, current, power, etc. I use channel to indicate the number of switches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comparable to shellies? As in, can the 2 channels exist in their own room? Because in shelly since last release, the integration would split the channels in their own device, allowing users to easily set them to their own room.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current it only can set to one room

image

@home-assistant home-assistant bot marked this pull request as draft June 17, 2025 09:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@zerzhang zerzhang force-pushed the feature/add_garage_door_opener_and_2pm branch from a23ac4b to f791bf4 Compare June 27, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek joostlek requested changes

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Danielhiversen Danielhiversen

Labels
by-code-owner cla-signed code-quality has-tests integration: switchbot new-feature Quality Scale: gold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zerzhang @epenet @joostlek @Danielhiversen