Skip to content

Fixed issue when tests (should) fail in Smarla #146102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2025
Merged

Fixed issue when tests (should) fail in Smarla #146102

merged 3 commits into from
Jun 26, 2025

Conversation

rlint-explicatis
Copy link
Contributor

@rlint-explicatis rlint-explicatis commented Jun 3, 2025 •
edited
Loading

Proposed change

Fix issue when tests (should) fail, causing them to not fail or create lingering tasks.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 3, 2025

Hey there @explicatis, mind taking a look at this pull request as it has been labeled with an integration (smarla) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smarla can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smarla Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

frenck
frenck previously requested changes Jun 3, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft June 3, 2025 09:13
@home-assistant
Copy link

home-assistant bot commented Jun 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@rlint-explicatis rlint-explicatis force-pushed the smarla-integration-fix-tests branch from 93e9bad to 7d4d68a Compare June 3, 2025 10:05
@rlint-explicatis rlint-explicatis marked this pull request as ready for review June 3, 2025 10:06
@home-assistant home-assistant bot requested a review from frenck June 3, 2025 10:06
@rlint-explicatis rlint-explicatis force-pushed the smarla-integration-fix-tests branch from 7d4d68a to 5b1dd0d Compare June 17, 2025 11:35
@rlint-explicatis rlint-explicatis marked this pull request as draft June 17, 2025 12:12
@rlint-explicatis
Copy link
Contributor Author

One check fails, because ConfigEntryAuthFailed is thrown in async_setup_entry but reauthentication flow is not implemented. This seems to be a new requirement and is something for a new PR or?

@rlint-explicatis rlint-explicatis marked this pull request as ready for review June 17, 2025 12:45
@rlint-explicatis
Copy link
Contributor Author

One check fails, because ConfigEntryAuthFailed is thrown in async_setup_entry but reauthentication flow is not implemented. This seems to be a new requirement and is something for a new PR or?

*This occured after rebasing

@joostlek
Copy link
Member

Instead you should raise ConfigEntryError for now

@joostlek joostlek marked this pull request as draft June 25, 2025 08:25
@rlint-explicatis rlint-explicatis marked this pull request as ready for review June 26, 2025 13:03
@joostlek joostlek changed the title Fixed issue when tests (should) fail Fixed issue when tests (should) fail in Smarla Jun 26, 2025
@joostlek joostlek added this to the 2025.7.0 milestone Jun 26, 2025
@joostlek joostlek merged commit bc46894 into home-assistant:dev Jun 26, 2025
34 checks passed
frenck pushed a commit that referenced this pull request Jun 26, 2025
@rlint-explicatis @frenck
Fixed issue when tests (should) fail in Smarla (#146102)
d4b548b 
* Fixed issue when tests (should) fail

* Use usefixture decorator

* Throw ConfigEntryError instead of AuthFailed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@frenck frenck Awaiting requested review from frenck

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: smarla Quality Scale: bronze small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rlint-explicatis @joostlek @frenck