Skip to content

Fritz Device Tracker - Add speed attribute #145804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Fritz Device Tracker - Add speed attribute #145804

wants to merge 8 commits into from

Conversation

N1co93
Copy link
Contributor

@N1co93 N1co93 commented May 28, 2025

Breaking change

Proposed change

I noticed that one of my network devices is experiencing issues with its LAN connection. To help diagnose the problem, I would like to monitor the network speed.

This pull request adds the speed attribute to the device_tracker entities.

Just for transparency: this PR was created with the help of GitHub Copilot.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@N1co93 N1co93 requested review from chemelli74 and mib1185 as code owners May 28, 2025 13:08
home-assistant[bot]
home-assistant bot previously requested changes May 28, 2025
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @N1co93

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft May 28, 2025 13:08
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @AaronDavidSchneider, @chemelli74, @mib1185, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@N1co93 N1co93 marked this pull request as ready for review May 28, 2025 14:40
@home-assistant home-assistant bot dismissed their stale review May 28, 2025 14:40

Stale

mib1185
mib1185 requested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @N1co93 thanks for your contribution 👍
I've left some comments and questions, further we should als adjust and extend the tests to reflect this new attribute.

@home-assistant home-assistant bot marked this pull request as draft May 28, 2025 21:23
@N1co93
Copy link
Contributor Author

N1co93 commented Jun 24, 2025

I addressed all required changes.
Can anybody give me some information regarding the code-test? Where can I find information about it? I don't know how to write the test.

@mib1185
Copy link
Contributor

mib1185 commented Jun 24, 2025

You will find the tests in tests/components/fritz ... unfortunately we've no tests yet for the device trackers, so it's time to add some 😬 Let me know, if you need help to do so 👍

@N1co93
Copy link
Contributor Author

N1co93 commented Jun 24, 2025

I'm afraid, that my knowledge in programming and Python is to weak to write a new test :(
Actually I think a new test is out of scope of this PR.

What do your think about it?

@mib1185
Copy link
Contributor

mib1185 commented Jun 26, 2025

At the moment I'm struggling to add more extra state attributes, instead of add them as dedicated (sensor) entities. We usually prefer to migrate extra attributes into own entities, so the user can better use them in automations and dashboards and also dis-/enable them as needed. Further there is a feature request to add much more of these attributes, those we should re-consider to add these as separate entities and find a sane definition for which of them should be enabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mib1185 mib1185 mib1185 requested changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mib1185 mib1185

@chemelli74 chemelli74

Labels
cla-signed integration: fritz new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N1co93 @mib1185 @chemelli74