Skip to content

Custom sentence triggers should be marked as processed locally #145704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

Custom sentence triggers should be marked as processed locally #145704

merged 5 commits into from
Jun 24, 2025

Conversation

HarvsG
Copy link
Contributor

@HarvsG HarvsG commented May 27, 2025 •
edited
Loading

Proposed change

Currently, if a custom sentence is matched when an external conversation agent is configured and "Prefer handling intents locally" is enabled the debug panel will show it as not processed locally.
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (assist_pipeline) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of assist_pipeline can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign assist_pipeline Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@HarvsG HarvsG changed the title Mark custom sentence triggers a local agent Custom sentence triggers should be marked as processed locally May 27, 2025
@HarvsG
Copy link
Contributor Author

HarvsG commented May 27, 2025

Unrelated test is failing

@synesthesiam
Copy link
Contributor

Thanks! Please add a test to verify that this works correctly.

@HarvsG
Copy link
Contributor Author

HarvsG commented May 27, 2025 •
edited
Loading

Thanks! Please add a test to verify that this works correctly.

It wasn't clear to me where the UI gets the info from? Any ideas?

Edit: I think I'll probably modify this test:

core/tests/components/assist_pipeline/test_pipeline.py

Line 1039 in a220cfd

async def test_sentence_trigger_overrides_conversation_agent(

arturpragacz
arturpragacz suggested changes May 28, 2025
View reviewed changes
@HarvsG HarvsG requested a review from arturpragacz May 29, 2025 22:00
@HarvsG
Copy link
Contributor Author

HarvsG commented May 29, 2025 •
edited
Loading

Thanks! Please add a test to verify that this works correctly.

Tests added

Ready for (re)review

@joostlek joostlek moved this to Triage in Voice Jun 16, 2025
@joostlek joostlek added this to Voice Jun 16, 2025
@synesthesiam synesthesiam merged commit ad4fae7 into home-assistant:dev Jun 24, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Voice Jun 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@synesthesiam synesthesiam synesthesiam approved these changes

@arturpragacz arturpragacz arturpragacz approved these changes

@balloob balloob Awaiting requested review from balloob balloob is a code owner

Assignees

@balloob balloob

@synesthesiam synesthesiam

Labels
bugfix cla-signed integration: assist_pipeline Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom sentences created in the automations section have a false value of “Processed locally” in the debug menu.
4 participants
@HarvsG @synesthesiam @arturpragacz @balloob