Skip to content

Add button to set IR Lamp to AUTO #145387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Add button to set IR Lamp to AUTO #145387

wants to merge 17 commits into from

Conversation

avigeilpro
Copy link

@avigeilpro avigeilpro commented May 21, 2025 •
edited
Loading

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@avigeilpro
Add button to set IR Lamp to AUTO
7b40e56 
Add a simple button to set back setting IrCutFilter to AUTO
@avigeilpro avigeilpro requested a review from hunterjm as a code owner May 21, 2025 13:09
home-assistant[bot]
home-assistant bot previously requested changes May 21, 2025
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @avigeilpro

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added new-feature small-pr PRs with less than 30 lines. labels May 21, 2025
@home-assistant home-assistant bot marked this pull request as draft May 21, 2025 13:09
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @hunterjm, @jterrace, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@avigeilpro avigeilpro marked this pull request as ready for review May 21, 2025 17:18
@home-assistant home-assistant bot dismissed their stale review May 21, 2025 17:18

Stale

joostlek
joostlek requested changes May 21, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff is failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft May 21, 2025 20:40
hunterjm
hunterjm requested changes May 21, 2025
View reviewed changes
Copy link
Member

@hunterjm hunterjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calls the correct command according to the ONVIF Spec, but should be implemented as a select entity instead of a button. The way it is implemented currently will allow you to set it to auto the first time the button is pressed, but doesn't do anything when pressed multiple times.

image

@avigeilpro
Copy link
Author

avigeilpro commented May 22, 2025 •
edited
Loading

This calls the correct command according to the ONVIF Spec, but should be implemented as a select entity instead of a button. The way it is implemented currently will allow you to set it to auto the first time the button is pressed, but doesn't do anything when pressed multiple times.
image

There is already a switch to toggle ON and OFF the IRCutFilter, but there was no way to put it back to AUTO. As Home Assistant doesn't have a 3 state switch, the only way i saw to add this function was to put a new button that have the only purpose to set this setting to Auto.

@avigeilpro
Copy link
Author

Ruff is failing, can you take a look?

Done

@avigeilpro avigeilpro marked this pull request as ready for review May 22, 2025 07:58
@home-assistant home-assistant bot requested review from joostlek and hunterjm May 22, 2025 07:59
@joostlek
Copy link
Member

As Home Assistant doesn't have a 3 state switch

There is, it's a select entity

@avigeilpro avigeilpro closed this May 22, 2025
@avigeilpro avigeilpro reopened this May 22, 2025
@avigeilpro
Copy link
Author

Do you think i should close this PR and open a new one with the Select entity solution ?

@joostlek
Copy link
Member

You can also continue on this PR, I don't mind

@avigeilpro
Copy link
Author

i've made the select entity, add a new function to read the settings from the camera and update the select. Waiting to see what i need to do next (for sure i missed something, this is my first contribution and i look this language for only 2 days)

@avigeilpro
Copy link
Author

Hi, anybody could say me what i should do next ? I don't know if there is a problem or if i should just wait.
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@joostlek joostlek Awaiting requested review from joostlek

@hunterjm hunterjm Awaiting requested review from hunterjm hunterjm is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@hunterjm hunterjm

Labels
cla-signed integration: onvif new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avigeilpro @joostlek @hunterjm