Skip to content

Add number platform for LED brightness to air-Q #145385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add number platform for LED brightness to air-Q #145385

wants to merge 2 commits into from

Conversation

Sibgatulin
Copy link
Contributor

@Sibgatulin Sibgatulin commented May 21, 2025 •
edited
Loading

Proposed change

Each air-Q device is equipped with 2 LED strips that function as LED level indicators / bar graphs for two (configurable) sensors. This PR exposes a single number entity for each airq device, allowing to set the brightness of both strips simultaneously.
This is the changes to the backend aioairq package that permit such brightness control.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration (airq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Sibgatulin Sibgatulin mentioned this pull request May 21, 2025
Open
8 tasks
@Sibgatulin Sibgatulin force-pushed the feat/airq_number_platform branch from 7010337 to 311af0b Compare May 21, 2025 13:13
joostlek
joostlek requested changes May 21, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft May 21, 2025 14:07
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Sibgatulin Sibgatulin force-pushed the feat/airq_number_platform branch 2 times, most recently from 57203d9 to bb21fa0 Compare May 30, 2025 13:13
@Sibgatulin Sibgatulin marked this pull request as ready for review May 30, 2025 13:14
@home-assistant home-assistant bot requested a review from joostlek May 30, 2025 13:14
joostlek
joostlek requested changes May 30, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft May 30, 2025 18:01
@Sibgatulin Sibgatulin mentioned this pull request Jun 4, 2025
Merged
19 tasks
@Sibgatulin Sibgatulin force-pushed the feat/airq_number_platform branch from bb21fa0 to 4fc0501 Compare June 4, 2025 16:43
@Sibgatulin
Copy link
Contributor Author

this PR is currently waiting for #146169

@Sibgatulin Sibgatulin force-pushed the feat/airq_number_platform branch from 4fc0501 to f69d299 Compare June 6, 2025 08:56
@Sibgatulin
Copy link
Contributor Author

I believe, I addressed every comment, @joostlek.
I also believe it would be better if I squashed the commits in this PR (since after this PR is rebased on top of #146169, some of the commits here reflect a broken/incorrect state of the code + many small commits with fixes).
Are there any objections?

@Sibgatulin Sibgatulin force-pushed the feat/airq_number_platform branch from 353f466 to b703a52 Compare June 20, 2025 11:20
@Sibgatulin Sibgatulin marked this pull request as ready for review June 20, 2025 11:24
@home-assistant home-assistant bot requested a review from joostlek June 20, 2025 11:24
joostlek
joostlek requested changes Jun 20, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft June 20, 2025 11:27
@Sibgatulin Sibgatulin marked this pull request as ready for review June 26, 2025 10:34
@home-assistant home-assistant bot requested a review from joostlek June 26, 2025 10:34
@frenck frenck changed the title feat(airq): add number platform for LED brightness Add number platform for LED brightness to air-Q Jun 26, 2025
@Sibgatulin
feat(airq): add number platform for LED brightness
dd22829 
Brightness is fetched by `AirQCoordinator` in `_async_update_data`
and is expressed in %
@Sibgatulin
test(airq.number): simplify tests for the new entity
43a71f7
@Sibgatulin Sibgatulin force-pushed the feat/airq_number_platform branch from 7229533 to 43a71f7 Compare June 30, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed dependency has-tests integration: airq new-feature new-platform Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sibgatulin @joostlek