Update synology_srm to use ScannerEntity with config flow #144645
Conversation
rename file fix system info pathing clean up code, add node_id, add original params complete integration updates fixes after merge core: update to match original config
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @aerialls, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Hi there @noriega3 👋
Wow that is quite a bunch in this pull request. Great effort! However, as a result, the pull request has grown beyond a reasonable size.
I don't like doing this, but I have to ask you to split this PR into multiple smaller pull requests. See also:
https://developers.home-assistant.io/docs/review-process#creating-the-perfect-pr
In the end, having a coordinator + config flow + scanner entity changes + other refactorings in a single PR really isn't needed and makes reviewing very hard.
../Frenck
|
sounds good. I'll split it into different PRs. Context was I was originally fixing the intermittent drop offs of the integration, but evolved into the config flow and resulting it in me modernizing it, where it worked consistently. |
|
Please check out #145865 for a separated PR, started from the base integration again. |
Breaking change
This uses the config flow template (fairly similar to mikrotik's implementation) while still keeping the original synology_srm api by the original owner
Proposed change
Updated legacy integration to implement files like the coordinator, init, and consts in order for the config flow to work, this was updated to use ScannerEntity.
Type of change
Additional information
Since there is coming from the configuration.yml way, there was not a previous config entry flow implemented.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: