Skip to content

Remove backup helper #143558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

Remove backup helper #143558

merged 3 commits into from
Jun 30, 2025

Conversation

emontnemery
Copy link
Contributor

Proposed change

Remove the backup helper which was added by #139199

Rationale:
The backup helper was added to make it possible for frontend to start listening to backup events without requiring the backup integration to be loaded early during bootstrapping.

The complexity added by the backup helper is no longer needed, because frontend now waits for the backup integration to load thanks to home-assistant/frontend#24997 + home-assistant/frontend#25012

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

Did you check that no custom integrations are using any of the helpers?

MartinHjelmare
MartinHjelmare previously approved these changes Apr 24, 2025
View reviewed changes
zweckj
zweckj previously approved these changes Apr 24, 2025
View reviewed changes
@emontnemery emontnemery marked this pull request as draft April 24, 2025 11:31
@emontnemery
Copy link
Contributor Author

emontnemery commented Apr 24, 2025 •
edited
Loading

Did you check that no custom integrations are using any of the helpers?

I expect custom integrations to only use the helpers in tests, but I'll do a github search just in case

Edit: A github code search suggests the only custom integration importing the backup helper is https://github.com/bkjohnson/homeassistant-storj-integration, and that only uses the backup helper in tests

I found two additional custom integrations which implement a backup agent, https://github.com/airalab/homeassistant-robonomics-integration and https://github.com/LouisBrunner/ha-proton-drive, but they should not be affected by the change

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jun 23, 2025
@emontnemery emontnemery dismissed stale reviews from zweckj and MartinHjelmare via 1e1df78 June 30, 2025 10:02
@emontnemery emontnemery marked this pull request as ready for review June 30, 2025 10:02
@github-actions github-actions bot removed the stale label Jun 30, 2025
@emontnemery emontnemery merged commit 741a3d5 into dev Jun 30, 2025
48 checks passed
@emontnemery emontnemery deleted the remove_backup_helper branch June 30, 2025 12:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zweckj zweckj zweckj approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@jpbede jpbede Awaiting requested review from jpbede jpbede is a code owner

@Quentame Quentame Awaiting requested review from Quentame Quentame is a code owner

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 is a code owner

@tronikos tronikos Awaiting requested review from tronikos tronikos is a code owner

Assignees
No one assigned
Labels
cla-signed code-quality core has-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @MartinHjelmare @zweckj