Skip to content

Add Rexense integration #143262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Add Rexense integration #143262

wants to merge 2 commits into from

Conversation

GorgeOu
Copy link

@GorgeOu GorgeOu commented Apr 19, 2025 •
edited
Loading

Breaking change

Additional information

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

home-assistant[bot]
home-assistant bot previously requested changes Apr 19, 2025
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GorgeOu

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft April 19, 2025 13:13
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@GorgeOu GorgeOu marked this pull request as ready for review April 19, 2025 13:16
@GorgeOu GorgeOu mentioned this pull request Apr 19, 2025
Closed
8 tasks
joostlek
joostlek requested changes Apr 19, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device or service specific code should exist in its own library hosted on pypi

@home-assistant home-assistant bot marked this pull request as draft April 19, 2025 13:37
@GorgeOu GorgeOu mentioned this pull request Apr 19, 2025
Open
8 tasks
@GorgeOu GorgeOu marked this pull request as ready for review April 19, 2025 13:39
@home-assistant home-assistant bot requested a review from joostlek April 19, 2025 13:39
@joostlek joostlek marked this pull request as draft April 19, 2025 13:41
@GorgeOu GorgeOu force-pushed the feature/rexense_integration branch from 1914e6b to 395e2dd Compare April 22, 2025 07:33
@GorgeOu GorgeOu marked this pull request as ready for review April 22, 2025 07:34
@GorgeOu
Copy link
Author

GorgeOu commented Apr 28, 2025 •
edited
Loading

Device or service specific code should exist in its own library hosted on pypi

I’ve updated the source code per your feedback, move specific code to aiorexense. Could you please take another look? Thanks!

joostlek
joostlek requested changes Apr 28, 2025
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you have a proper development environment running. Also, what does Rexense do? What kind of devices do they sell and to what kind of devices does this connect?

@home-assistant home-assistant bot marked this pull request as draft April 28, 2025 16:44
@GorgeOu
Copy link
Author

GorgeOu commented Apr 29, 2025 •
edited
Loading

Please make sure you have a proper development environment running. Also, what does Rexense do? What kind of devices do they sell and to what kind of devices does this connect?

1. Development Environment & Testing

I have a proper development environment set up and have successfully verified device connectivity with the Rexense 3Phase Meter. Also I ran:
pre-commit run --files ./homeassistant/components/rexense/*
pytest tests/components/rexense/
Both checks passed without any errors and the integration is running smoothly.

2. About Rexense

Rexense is an IoT solutions provider specializing in wireless modules and devices. Their product lineup includes Zigbee, BLE, and Wi-Fi radio modules, gateways, and IoT devices. Website : https://www.rexense.com/

3. Current Projects & HA Integration

We are currently developing a Wi-Fi 3-Phase Electricity Meter and a Smart Plug for Home Assistant integration. Our primary target market is Germany. Using the initial version of the meter, I’ve confirmed that the Home Assistant integration works as expected. The Smart Plug integration will be merged shortly.

@joostlek
Copy link
Member

  1. Precommit hasn't been run correctly as this PR is missing files and the CI is failing
  2. So the device this is connecting with isn't available yet?

@GorgeOu
Copy link
Author

GorgeOu commented Apr 29, 2025 •
edited
Loading

  1. Precommit hasn't been run correctly as this PR is missing files and the CI is failing
  2. So the device this is connecting with isn't available yet?
  1. I’ll investigate the missing files and rerun the pre-commit checks to resolve the CI failures.
  2. The device itself is still in development; however, the protocol specification is fully finalized, and our validation meter already supports the complete protocol interaction. Therefore, I hope to be able to submit the integration in parallel.

@joostlek
Copy link
Member

We only allow integrations to be added for products that are available on the market though

@GorgeOu
Copy link
Author

GorgeOu commented Apr 29, 2025

We only allow integrations to be added for products that are available on the market though

Understood. I’ll update the integration once the device is officially on the market. Thank you.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jun 28, 2025
@GorgeOu
Copy link
Author

GorgeOu commented Jun 28, 2025

keep it open

@github-actions github-actions bot removed the stale label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek joostlek requested changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed has-tests integration: rexense new-integration quality-scale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GorgeOu @joostlek