Add new SmartThings dryer-washer button capabilities #142764
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
requested changes
Jun 23, 2025
Comment on lines
+28
to
+54
| Capability.SAMSUNG_CE_WASHER_OPERATING_STATE: { | ||
| Command.START: [ | ||
| SmartThingsButtonEntityDescription( | ||
| key=Command.START, | ||
| translation_key="state_start", | ||
| ) | ||
| ], | ||
| Command.CANCEL: [ | ||
| SmartThingsButtonEntityDescription( | ||
| key=Command.CANCEL, | ||
| translation_key="state_cancel", | ||
| ) | ||
| ], | ||
| Command.RESUME: [ | ||
| SmartThingsButtonEntityDescription( | ||
| key="pause_resume", | ||
| translation_key="state_pause_resume", | ||
| command_list=[Command.PAUSE, Command.RESUME], | ||
| ) | ||
| ], | ||
| Command.ESTIMATE_OPERATION_TIME: [ | ||
| SmartThingsButtonEntityDescription( | ||
| key=Command.ESTIMATE_OPERATION_TIME, | ||
| translation_key="estimate_operation_time", | ||
| ) | ||
| ], | ||
| }, |
There was a problem hiding this comment.
I think at this point it would make sense to add buttons instead of a select entity. But I think we can use the standard capability instead of the samsungce one
There was a problem hiding this comment.
From my washer API command list 75% (72 of the 96) starts with samsungce. Why you interpreter samsungce commands as non-standard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
SmartThings integration: standardize button code, add dryer/washer capabilities start, cancel, pause-resume, estimate operation timeType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: