-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Migrate device connections to a normalized form #140383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate device connections to a normalized form #140383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some context on the PR description to what this is fixing/why is it needed?
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Not stale |
I want to take another look at this to triple confirm it doesn't risk breaking anything, including downgrade. I'll try to get to that during next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, thanks @arturpragacz and sorry about the slow review 👍
Maybe we should guard against accidentally breaking in the future by validating DeviceEntry.connections
though.
eb9f2c8
to
68e191e
Compare
68e191e
to
65961f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @arturpragacz 👍
Proposed change
Migrate device connections to a normalized form.
We want to ensure that all the device connections in the registry are in a normalized form.
Unfortunately we didn't guarantee that in the past.
All the paths through which connections are provided by integrations now ensure that the connections are normalized. The last one that didn't guarantee it, I removed in #134100.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: