Add Beoremote One support to Bang & Olufsen #138857
Conversation
| """Event class for Beoremote One key events.""" | ||
|
|
||
| _attr_event_types = BEO_REMOTE_KEY_EVENTS | ||
| _attr_icon = "mdi:remote" |
There was a problem hiding this comment.
I used icon translations previously, but as there are 90 different entities, it would require 274 lines instead of just one, which seemed silly.
There was a problem hiding this comment.
Right, I realised that later. Would it be helpful to use translation placeholders?
There was a problem hiding this comment.
I don't think so, as it is the key and not value that is the problem:
"control_digit5": {
"default": "mdi:remote"
},
"control_digit6": {
"default": "mdi:remote"
}|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Is there anything missing from this PR? |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Add initial support for the Beoremote One, by adding it as a Home Assistant device via compatible paired B&O devices. Event entities (that are disabled by default) are created for each of the possible triggers. There are 90 different triggers, each with a "press" and "release" state.
Currently the config entry is reloaded to add or remove paired remotes from Home Assistant. This may not be the best way to handle this.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: