-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Add support for Tuya bitmap sensors #137771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Please don't close this PR. The code works, and solves a real problem. I just need somebody to review it. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Please don't close this PR. The code works, and solves a real problem. I just need somebody to review it. |
Proposed change
I have a Meaco Arete Two dehumidifier. This PR enables home assistant to detect when the water tank is full.
There is some discussion of the Meaco Arete Two here, which is where I learned that it uses Tuya. But after setting up the Tuya integration, I discovered that it couldn't read the "tank full" status, which is the main thing that I want to do. On further investigation, I discovered that the "tank full" is reported using the Bitmap type, which isn't currently supported by the Tuya integration. So the main contribution of this PR to add support for Bitmaps.
I don't think a Bitmap datatype would be convenient in home assistant because then the user would have to do bit twiddling to extract the information that they want. So I've set it up so that every bit that you're interested in gets converted into a separate binary sensor.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: