-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Add possibility to synchronize automatically all available feeds in emoncms #128122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to synchronize automatically all available feeds in emoncms #128122
Conversation
Hey there @borpin, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does once mean? They all get added to HA and then get synchronized all the time right?
Ýes exactly. That is something asked last week by some users at openenergymonitor. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Remove checkbox in options
Hi there @alexandrecuer 👋 Any reason this PR is currently sitting in draft? ../Frenck |
@frenck : sorry, it is a mistake from my side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @alexandrecuer 👍
"auto": "Synchronize all available Feeds", | ||
"manual": "Select which Feeds to synchronize" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here "feeds" should be sentence-cased, not capitalized, as this is a word that becomes translated in most languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the emoncms world, Feeds is a thing not a description, so 'Feeds' is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for clarifying. In German it does not make a difference as we "translate" this as "Feeds" anyhow.
But you might want to add a note in Lokalise so this is treated as a name in other languages and not translated.
Proposed change
Add possibility to synchronize all the available feeds without having to choose them one by one with the selector
If the manual option (default) is selected, next screen show the selector with the list of available feeds
if the auto option is selected, the entry is directly created with as many entities as available feeds in the emoncms instance
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: