Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hassfest should check if all used abort reasons are in the translations file #31005

Open
frenck opened this issue Jan 20, 2020 · 1 comment
Open

hassfest should check if all used abort reasons are in the translations file #31005

frenck opened this issue Jan 20, 2020 · 1 comment
Labels
help-wanted Wanna help? Jump in!
Projects
Cleanup & Polishing

Comments

@frenck
Copy link
Member

frenck commented Jan 20, 2020 •
edited
Loading

Description of problem:

hassfest is run by our CI to check for common issues with integrations and prevents them from being merged, and this prevents them from ending up in our codebase.

Recently, we have discovered some configuration flows that use abort reasons that are not defined in the translations file. We should use hassfest to check for this.

Some are implied/not clear from the config flow of the integration itself, for example, when using _abort_if_unique_id_configured or the OAuth helpers.
@frenck frenck added the help-wanted Wanna help? Jump in! label Jan 20, 2020
@frenck frenck added this to To do in Cleanup & Polishing Jan 20, 2020
@frenck frenck moved this from To do - Other to To do - Backend in Cleanup & Polishing Jan 22, 2020
@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted Wanna help? Jump in!
Projects
No open projects
Cleanup & Polishing
  
To do - Backend
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frenck