Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix race condition for create Preview Apps API #10287

Open
meetzaveri opened this issue Jun 11, 2024 · 0 comments
Open

fix: fix race condition for create Preview Apps API #10287

meetzaveri opened this issue Jun 11, 2024 · 0 comments
Labels
k/bug Something isn't working

Comments

@meetzaveri
Copy link
Member

Version Information

Server Version: 2.39

Environment

Cloud

What is the current behaviour?

As per this doc for create preview apps API, when user performs this mutation to create preview app, it returns a response containing two preview project ids instead of one preview project id. This also creates two projects on Hasura cloud dashboard as well.

For cloud users, this also arises the issue of reaching 3 free tier project limit since duplicate project holds the extra spot for free tier project limit.

What is the expected behaviour?

Using Create Preview Apps API , it should create one preview app project instead of 2 projects.

How to reproduce the issue?

  1. First gather the PAT from Hasura cloud. Please refer this page.
  2. Then use API tool like Postman and devise an API.
  3. It's a part of Hasura cloud API , so please familiarise your self to cloud API reference
  4. Setup authentication (request headers) as suggested per this doc in your API req.
  5. Once request headers and request body are set, perform createGitHubPreviewApp mutation and check the response.

Screenshots or Screencast

get_preview_apps_creation_status_api_response

Any possible solutions/workarounds you're aware of?

You can manually delete that duplicate preview app in Hasura cloud dashboard.

Keywords

preview apps hasura cloud

@meetzaveri meetzaveri added the k/bug Something isn't working label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant