Skip to content

samples: Add samples for soft_deleted_buckets #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 6, 2025

Conversation

chandra-siri
Copy link
Contributor

@chandra-siri chandra-siri commented Apr 16, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.

    yes - Samples for Bucket Restore #1455

  • Ensure the tests and linter pass

  • Code coverage does not decrease (if any source code was changed)
    No source code changed.

  • Appropriate docs were updated (if necessary) - NA

Fixes #1455

@chandra-siri chandra-siri requested review from a team as code owners April 16, 2025 09:20
@chandra-siri chandra-siri linked an issue Apr 16, 2025 that may be closed by this pull request
Copy link

snippet-bot bot commented Apr 16, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 16, 2025
@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Apr 16, 2025
Copy link
Contributor

@JesseLovelace JesseLovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All samples need to have tests, please add them

@chandra-siri
Copy link
Contributor Author

All samples need to have tests, please add them

Done. @JesseLovelace Please check.

@chandra-siri chandra-siri requested a review from cojenco April 21, 2025 08:18
@chandra-siri chandra-siri changed the title samples: Add samples for soft_deleted_buckets chore: Add samples for soft_deleted_buckets Apr 22, 2025
@chandra-siri chandra-siri changed the title chore: Add samples for soft_deleted_buckets samples: Add samples for soft_deleted_buckets Apr 22, 2025
Copy link

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM from feature perspective, just two nit comments.

Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and questions, otherwise LGTM too

@chandra-siri chandra-siri requested a review from JesseLovelace May 5, 2025 10:02
@chandra-siri chandra-siri requested review from a team, leahecole and holtskinner and removed request for holtskinner, a team and leahecole May 5, 2025 10:03
@holtskinner holtskinner removed their request for review May 5, 2025 15:20
@holtskinner holtskinner requested review from JesseLovelace and removed request for JesseLovelace May 5, 2025 15:21
@chandra-siri chandra-siri dismissed JesseLovelace’s stale review May 6, 2025 13:28

Already got approvals from 3 People.

@chandra-siri chandra-siri merged commit 5cfb7a5 into main May 6, 2025
14 checks passed
@chandra-siri chandra-siri deleted the 1455-samples-for-bucket-restore branch May 6, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples for Bucket Restore
5 participants