Skip to content

feat: support commit timestamp option #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

waltaskew
Copy link
Contributor

Add support for columns with commit timestamps:
https://cloud.google.com/spanner/docs/commit-timestamp

Fixes: #695

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jun 16, 2025
@waltaskew waltaskew force-pushed the support-commit-timestamps branch from 3d363a1 to 70744d4 Compare June 16, 2025 21:39
olavloite
olavloite previously approved these changes Jun 19, 2025
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! LGTM

@olavloite
Copy link
Contributor

@waltaskew Would you mind taking a look at why the sample test run fails?

@waltaskew waltaskew force-pushed the support-commit-timestamps branch from 1925ac8 to 7390c80 Compare June 23, 2025 16:24
@waltaskew
Copy link
Contributor Author

waltaskew commented Jun 23, 2025

@waltaskew Would you mind taking a look at why the sample test run fails?

Ah, sorry, missing import in the sample. Fixed!

@waltaskew waltaskew force-pushed the support-commit-timestamps branch from 7390c80 to 69ea1a2 Compare June 23, 2025 16:25
olavloite
olavloite previously approved these changes Jun 27, 2025
@olavloite olavloite force-pushed the support-commit-timestamps branch from 66838d8 to 5211be9 Compare June 27, 2025 10:37
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2025
@olavloite olavloite requested a review from aakashanandg June 27, 2025 10:50
@olavloite olavloite merged commit 82bb8ed into googleapis:main Jun 27, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Commit Timestamp Columns
4 participants