Skip to content

Fix: Surface Fatal Stream Errors to Future; Adjust Retryable Error Codes #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 24, 2025
Merged

Fix: Surface Fatal Stream Errors to Future; Adjust Retryable Error Codes #1422

merged 18 commits into from
Jun 24, 2025

Conversation

abbrowne126
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1415

@abbrowne126 abbrowne126 requested review from a team as code owners June 16, 2025 14:04
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Jun 16, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 17, 2025
@abbrowne126
Copy link
Collaborator Author

@parthea , can you please review this when you get a chance?

parthea
parthea approved these changes Jun 23, 2025
View reviewed changes
@abbrowne126 abbrowne126 enabled auto-merge (squash) June 23, 2025 13:36
@abbrowne126 abbrowne126 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2025
@abbrowne126 abbrowne126 merged commit e081beb into googleapis:main Jun 24, 2025
25 checks passed
@release-please release-please bot mentioned this pull request Jun 24, 2025
Open
@abbrowne126 abbrowne126 mentioned this pull request Jun 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@michaelpri10 michaelpri10 michaelpri10 approved these changes

Assignees

@parthea parthea

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align Stream Retry and Termination Behavior With Canonical API Retry Policies; Surface Fatal Errors Immediately
4 participants
@abbrowne126 @parthea @michaelpri10 @yoshi-kokoro