Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix formatting of request arg in docstring #894

Merged
merged 9 commits into from
Apr 4, 2023
Merged

docs: Fix formatting of request arg in docstring #894

merged 9 commits into from
Apr 4, 2023

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Apr 1, 2023 •
edited

Manually porting non-rest related changes:

docs: Fix formatting of request arg in docstring
chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2ab4b0a0ae2907e812c209198a74e0898afcb04
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

BEGIN_NESTED_COMMIT
chore: Update gapic-generator-python to v1.9.0
PiperOrigin-RevId: 517425588

Source-Link: googleapis/googleapis@33c93eb

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d5f59789d19fc43270ff2124967d4ec8992b8e8f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDVmNTk3ODlkMTlmYzQzMjcwZmYyMTI0OTY3ZDRlYzg5OTJiOGU4ZiJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: Update gapic-generator-python to v1.8.5
PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: https://github.com/googleapis/googleapis-gen/commit/1907294b1d8365ea24f8c5f2e059a64124c4ed3b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9
END_NESTED_COMMIT

gcf-owl-bot bot and others added 7 commits April 1, 2023 11:29
@gcf-owl-bot @acocuzzo
chore: Update gapic-generator-python to v1.8.5
038e97e 
PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9
@gcf-owl-bot @acocuzzo
🦉 Updates from OwlBot post-processor
593e074 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@acocuzzo
remove rest.py
2b9e8ae
@gcf-owl-bot @acocuzzo
chore: Update gapic-generator-python to v1.9.0
1396144 
PiperOrigin-RevId: 517425588

Source-Link: googleapis/googleapis@33c93eb

Source-Link: googleapis/googleapis-gen@d5f5978
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDVmNTk3ODlkMTlmYzQzMjcwZmYyMTI0OTY3ZDRlYzg5OTJiOGU4ZiJ9
@gcf-owl-bot @acocuzzo
🦉 Updates from OwlBot post-processor
c71e05a 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot @acocuzzo
docs: Fix formatting of request arg in docstring
7df48fa 
chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9
@gcf-owl-bot @acocuzzo
🦉 Updates from OwlBot post-processor
c6e8913 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@acocuzzo acocuzzo requested review from a team as code owners April 1, 2023 15:42
@acocuzzo acocuzzo requested a review from rsamborski April 1, 2023 15:42
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 1, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2023
@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2023
@acocuzzo acocuzzo changed the title Docs: Port owlbot changes docs: Fix formatting of request arg in docstring Apr 2, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2023
vchudnov-g
vchudnov-g reviewed Apr 3, 2023
View reviewed changes
Copy link

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but one question about samples version. Everything else is just doc, so should be fine to merge.

samples/generated_samples/snippet_metadata_google.pubsub.v1.json Show resolved Hide resolved
@acocuzzo acocuzzo mentioned this pull request Apr 3, 2023
Merged
@acocuzzo acocuzzo merged commit ee2ea73 into googleapis:main Apr 4, 2023
@release-please release-please bot mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g left review comments

@pradn pradn pradn approved these changes

@rsamborski rsamborski Awaiting requested review from rsamborski rsamborski is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@pradn pradn

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acocuzzo @pradn @vchudnov-g @yoshi-kokoro