Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update missing docstrings #890

Merged
merged 2 commits into from
Mar 20, 2023
Merged

docs: update missing docstrings #890

merged 2 commits into from
Mar 20, 2023

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Mar 20, 2023 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Adds docstrings that were missing in the public documentation. This caused some of the content to not be rendered and be missing.

Fixes b/260130444 馃

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Mar 20, 2023
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@dandhlee dandhlee marked this pull request as ready for review March 20, 2023 19:51
@dandhlee dandhlee requested review from a team as code owners March 20, 2023 19:51
acocuzzo
acocuzzo approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan!

@acocuzzo acocuzzo merged commit 5849e04 into main Mar 20, 2023
@acocuzzo acocuzzo deleted the add_missing_docstrings branch March 20, 2023 20:01
@release-please release-please bot mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acocuzzo acocuzzo acocuzzo approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dandhlee @acocuzzo