Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable "rest" transport in Python for services supporting numeric enums #863

Merged
merged 40 commits into from
Apr 6, 2023
Merged

feat: enable "rest" transport in Python for services supporting numeric enums #863

merged 40 commits into from
Apr 6, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 8, 2023 •
edited by acocuzzo

BEGIN_NESTED_COMMIT
feat: enable "rest" transport in Python for services supporting numeric enums
PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/6ad1279c0e7aa787ac6b66c9fd4a210692edffcd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9
END_NESTED_COMMIT
Fixes #868

@gcf-owl-bot
feat: enable "rest" transport in Python for services supporting numer…
757bb79 
…ic enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners February 8, 2023 22:15
@snippet-bot
Copy link

snippet-bot bot commented Feb 8, 2023 •
edited

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Feb 8, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Feb 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 8, 2023 22:17
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@gcf-owl-bot
feat: Add google.api.method.signature to update methods
b669896 
PiperOrigin-RevId: 509649352

Source-Link: googleapis/googleapis@1870ba2

Source-Link: googleapis/googleapis-gen@515dcdf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTE1ZGNkZmRkMjdmZjAwYzMwZTU1NWJkZjE3Yjc3NDNlMjE0NTdlOSJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: enable "rest" transport in Python for services supporting numeric enums feat: Add google.api.method.signature to update methods Feb 15, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2023
vchudnov-g
vchudnov-g reviewed Apr 3, 2023
View reviewed changes
Copy link

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner of the manual layer: what is the status of this? Are we ready to merge?

@acocuzzo
Copy link
Contributor

acocuzzo commented Apr 3, 2023

As you can see, the REST related changes do not pass multiple system tests, so there is work to be done to determine what tests should be skipped, or can be fixed. (with googleapis owners).
As for the other changes, I have been manually porting non-rest related commits in PRs such as: #894

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@acocuzzo acocuzzo changed the title docs: Fix formatting of request arg in docstring feat: enable "rest" transport in Python for services supporting numeric enums Apr 4, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@acocuzzo acocuzzo merged commit a80c1d1 into main Apr 6, 2023
14 checks passed
@acocuzzo acocuzzo deleted the owl-bot-copy branch April 6, 2023 14:04
@release-please release-please bot mentioned this pull request Apr 6, 2023
Merged
@vchudnov-g vchudnov-g mentioned this pull request Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g left review comments

@acocuzzo acocuzzo acocuzzo approved these changes

@kweinmeister kweinmeister Awaiting requested review from kweinmeister kweinmeister was automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add REST transport to system tests
3 participants
@acocuzzo @vchudnov-g @yoshi-kokoro