Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Silence invalid_ack_id warnings for receipt modacks #798

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Fix: Silence invalid_ack_id warnings for receipt modacks #798

merged 2 commits into from
Oct 6, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Oct 5, 2022

Following fixes for: #786
We should also silence the warnings for these expired messages since they are irrelevant to the user.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Oct 5, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2022
@acocuzzo acocuzzo marked this pull request as ready for review October 5, 2022 21:49
@acocuzzo acocuzzo requested review from a team as code owners October 5, 2022 21:49
@acocuzzo acocuzzo added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 6, 2022
@acocuzzo acocuzzo merged commit 17feea5 into googleapis:main Oct 6, 2022
@release-please release-please bot mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshgattani maheshgattani maheshgattani approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acocuzzo @maheshgattani