Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unit test failures in https://github.com/googleapis/python-pubsu… #1074

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: unit test failures in https://github.com/googleapis/python-pubsu… #1074

merged 1 commit into from
Feb 8, 2024

Conversation

mukund-ananthu
Copy link
Contributor

…b/pull/1064

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners February 8, 2024 04:15
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 8, 2024
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Feb 8, 2024
@parthea parthea mentioned this pull request Feb 8, 2024
Open
parthea
parthea reviewed Feb 8, 2024
View reviewed changes
pytest.ini Show resolved Hide resolved
@ohmayr
Copy link

ohmayr commented Feb 8, 2024

Please try updating credentials.AnonymousCredentials to credentials.AnonymousCredentials(). Let me know if that works!

@mukund-ananthu
Copy link
Contributor Author

Please try updating credentials.AnonymousCredentials to credentials.AnonymousCredentials(). Let me know if that works!

@ohmayr Making this change, results in unit tests passing now. Thanks.

@mukund-ananthu mukund-ananthu merged commit 3c6d128 into main Feb 8, 2024
27 of 28 checks passed
@mukund-ananthu mukund-ananthu deleted the gapicErr branch February 8, 2024 19:02
@release-please release-please bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mukund-ananthu @ohmayr @parthea @pradn