Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repeated structured property containing blob property with legacy_data (#817) #946

Merged
merged 7 commits into from
Feb 29, 2024
Merged

fix: repeated structured property containing blob property with legacy_data (#817) #946

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5335a9
Fix issue 817
ventice Feb 13, 2024
50590b5
Fix issue 817
ventice Feb 13, 2024
7ad1023
Merge branch 'main' into main
ventice11o Feb 13, 2024
2f1ab13
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 13, 2024
054ea5f
Merge branch 'main' into main
sorced-jim Feb 27, 2024
6769033
Merge branch 'main' into main
sorced-jim Feb 28, 2024
7f719a5
Merge branch 'main' into main
sorced-jim Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Fix issue 817
  • Loading branch information
@ventice
ventice committed Feb 13, 2024
commit f5335a91beb85e59170c4f345f1d8114e66ca8eb
42 changes: 42 additions & 0 deletions tests/unit/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,6 +1792,48 @@ class ThisKind(model.Model):
compressed_value_two,
]

@staticmethod
def test__to_datastore_legacy_compressed_repeated_in_parent(in_context):
class ThisKind(model.Model):
bar = model.BlobProperty(compressed=True, repeated=False)

class ParentKind(model.Model):
foo = model.StructuredProperty(ThisKind, repeated=True)

with in_context.new(legacy_data=True).use():
uncompressed_value_one = b"abc" * 1000
compressed_value_one = zlib.compress(uncompressed_value_one)
uncompressed_value_two = b"xyz" * 1000
compressed_value_two = zlib.compress(uncompressed_value_two)
entity = ParentKind(foo=[ThisKind(bar=uncompressed_value_one), ThisKind(bar=uncompressed_value_two)])
ds_entity = model._entity_to_ds_entity(entity)
assert "foo.bar" not in ds_entity._meanings
assert "foo.bar" in ds_entity.keys()
assert ds_entity.get("foo.bar") == [
compressed_value_one,
compressed_value_two
]

@staticmethod
def test__to_datastore_legacy_compressed_repeated_in_parent_uninitialized(in_context):
class ThisKind(model.Model):
bar = model.BlobProperty(compressed=True, repeated=False)

class ParentKind(model.Model):
foo = model.StructuredProperty(ThisKind, repeated=True)

with in_context.new(legacy_data=True).use():
uncompressed_value = b"abc" * 1000
compressed_value = zlib.compress(uncompressed_value)
entity = ParentKind(foo=[ThisKind(), ThisKind(bar=uncompressed_value)])
ds_entity = model._entity_to_ds_entity(entity)
assert "foo.bar" not in ds_entity._meanings
assert "foo.bar" in ds_entity.keys()
assert ds_entity.get("foo.bar") == [
None,
compressed_value
]

@staticmethod
@pytest.mark.usefixtures("in_context")
def test__to_datastore_compressed_uninitialized():
Expand Down