Skip to content

chore(.github): Update python logging issues and prs assignee #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

chore(.github): Update python logging issues and prs assignee #825

merged 2 commits into from
Dec 12, 2023

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
This is to update the PR and issue auto-assignees to api-logging-python-reviewers group.

@cindy-peng cindy-peng requested review from a team as code owners December 6, 2023 20:21
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 6, 2023
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Dec 6, 2023
parthea
parthea requested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you check if googleapis/api-logging-python-reviewers is a TeamSync managed team rather than a Github team?

For example,
https://github.com/orgs/googleapis/teams/python-core-client-libraries is a
TeamSync managed team

But api-logging-python-reviewers does not appear to be.

https://github.com/orgs/googleapis/teams/api-logging-python-reviewers

@cindy-peng
Copy link
Contributor Author

Please could you check if googleapis/api-logging-python-reviewers is a TeamSync managed team rather than a Github team?

For example, https://github.com/orgs/googleapis/teams/python-core-client-libraries is a TeamSync managed team

But api-logging-python-reviewers does not appear to be.

https://github.com/orgs/googleapis/teams/api-logging-python-reviewers

Thank you for the feedback @parthea! Yesapi-logging-python-reviewers is not a TeamSync team, and we do have a work item to onboard to TeamSync for the entire logging team as next steps:https://docs.google.com/document/d/1HZ33smfg_58MxTFQep3v0W8NNgcB1kyAKHMSc5axazs/edit?disco=AAABB0gCZTw
Considering we will need language specific mdb groups for different languages and have TeamSync set up accordingly, that may take a while for the logging team. While we are working on that, this change is to help us assign issues and PRs to the right owner before we onboard to TeamSync.

@parthea parthea merged commit b06ef0c into main Dec 12, 2023
@parthea parthea deleted the cindy/update-assignees branch December 12, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cindy-peng @parthea @daniel-sanche