Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set partial_success to default to true for batched logs #649

Merged
merged 7 commits into from
Oct 17, 2022

Conversation

daniel-sanche
Copy link
Contributor

By default, if one log in a batch fails (ex: due to large size), the entire batch will be dropped. This PR sets the partial_success flag by default, so other logs will still be processed. We also expose partial_success as an optional argument to batch.commit(), so users can override the behavior if needed.

Note that most logger.log functions only typically write a single log entries, so this functionality is only strictly needed for batching. The only exception is when writing instrumentation logs, where a logger.log call may write two entries. For this reason, partial_success is always set to true for these calls

Fixes #448

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/python-logging API. labels Oct 11, 2022
@daniel-sanche daniel-sanche changed the title set partial_success to default to true for batched logs [DRAFT] feat: set partial_success to default to true for batched logs Oct 12, 2022
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, lets have a discussion about it

@daniel-sanche daniel-sanche marked this pull request as ready for review October 17, 2022 17:28
@daniel-sanche daniel-sanche requested review from a team as code owners October 17, 2022 17:28
@daniel-sanche daniel-sanche changed the title [DRAFT] feat: set partial_success to default to true for batched logs feat: set partial_success to default to true for batched logs Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for partialSuccess flag in entries.write request for oversized log entries
2 participants