feat: set partial_success to default to true for batched logs #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, if one log in a batch fails (ex: due to large size), the entire batch will be dropped. This PR sets the
partial_success
flag by default, so other logs will still be processed. We also exposepartial_success
as an optional argument tobatch.commit()
, so users can override the behavior if needed.Note that most
logger.log
functions only typically write a single log entries, so this functionality is only strictly needed for batching. The only exception is when writing instrumentation logs, where alogger.log
call may write two entries. For this reason,partial_success
is always set to true for these callsFixes #448