Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added generated docs for async client #947

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Mar 20, 2024

Added autogenerated sphinx docs pages for async data client

Currently serving them in the Using the API section:

image


To view docs locally:

  • run nox -s docs to generate html pages
  • run python -m http.server -d ./docs/_build/html to start a local server on localhost:8000

BEGIN_COMMIT_OVERRIDE
chore(docs): added generated docs for async client
END_COMMIT_OVERRIDE

@daniel-sanche daniel-sanche requested review from a team as code owners March 20, 2024 23:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 20, 2024
docs/usage.rst Outdated
@@ -1,5 +1,5 @@
Using the API
=============
Using the Standard Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: standard client -> sync client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually there will be two sync clients, so we'll need a different naming system. I'll change it to sync for now though, we can discuss that later!

@daniel-sanche daniel-sanche merged commit 053a6ee into googleapis:main Mar 20, 2024
27 of 29 checks passed
@daniel-sanche daniel-sanche deleted the generate_async_docs branch March 20, 2024 23:43
@daniel-sanche daniel-sanche changed the title feat: added generated docs for async client chore(docs): added generated docs for async client Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants