feat: Reworked the wait_for_consistency call #1144
Merged
+315
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
approved these changes
Jun 25, 2025
| The result type for the operation will be `bool`, and will return True when the | ||
| consistency check involving the given consistency token returns True. | ||
| bool: | ||
| Returns `True` after the mutations of the specified table have been fully replicated |
There was a problem hiding this comment.
nit: I think you should add a Raises section, like the one here: https://github.com/googleapis/python-api-core/blob/2c983853e930d1ad4a3ece6b6b55a6dc72206a17/google/api_core/future/polling.py#L252
mutianf
reviewed
Jun 26, 2025
google/cloud/bigtable/admin_v2/overlay/services/bigtable_table_admin/client.py
Show resolved
Hide resolved
google/cloud/bigtable/admin_v2/overlay/services/bigtable_table_admin/client.py
Outdated
Show resolved
Hide resolved
…_admin/client.py Co-authored-by: Mattie Fu <[email protected]>
mutianf
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
WaitForConsistencyRequestas an input parameter forwait_for_consistency. The wrapper class is proto plus based to be consistent with other GAPIC calls.wait_for_consistencynow generates a consistency token viagenerate_consistency_tokenthen blocks on the polling harness, rather than returning the polling harness directly. This is consistent with the way Java does things.wait_for_replication.