feat: df.join lsuffix and rsuffix support #1857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Jul 1, 2025
| if how == "cross": | ||
| if on is not None: | ||
| raise ValueError("'on' is not supported for cross join.") | ||
| result_block = left._block.merge( | ||
| right._block, | ||
| left_join_ids=[], | ||
| right_join_ids=[], | ||
| suffixes=("", ""), | ||
| suffixes=(lsuffix, rsuffix), | ||
| how="cross", | ||
| sort=True, | ||
| ) | ||
| return DataFrame(result_block) | ||
|
|
||
| # Join left columns with right index | ||
| if on is not None: |
There was a problem hiding this comment.
Nit: This if block is getting pretty long. Might be time for a helper function.
| ["string_col", "int64_col", "int64_too"] | ||
| ].rename(columns={"int64_too": "int64_col"}) | ||
| pd_result = pd_df_a.join(pd_df_b, how=how, lsuffix="_l", rsuffix="_r") | ||
| print(pd_result) |
There was a problem hiding this comment.
Remove leftover print() statements.
PS. Adding --pdb to your pytest command line arguments makes dropping into a debugger to inspect variables really easy. https://docs.pytest.org/en/stable/how-to/failures.html#dropping-to-pdb-on-failures
Comment on lines
+2469
to
+2470
| if how == "cross": | ||
| return |
There was a problem hiding this comment.
I think it'd be worth added a test that ValueError is not raise for this condition with a cross join.
There was a problem hiding this comment.
Cross join actually raise another error, match added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕