chore: add compile_join for new compiler #1851
Merged
+164
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBergeron
previously approved these changes
Jun 25, 2025
| join_nulls: bool = True, | ||
| ) -> SQLGlotIR: | ||
| """Joins the current query with another SQLGlotIR instance.""" | ||
| # TODO: add join_nulls support |
There was a problem hiding this comment.
maybe just throw a NotImplementedError now for join_nulls? Def don't want to forget to implement that flag later on
There was a problem hiding this comment.
To prevent large changes, I will send out PR soon for join_nulls supports.
e273d7a to
c745875
Compare
TrevorBergeron
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 427501553 🦕