Skip to content

fix: add google-auth as a direct dependency #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 8, 2024
Merged

fix: add google-auth as a direct dependency #1809

merged 12 commits into from
Mar 8, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 6, 2024 •
edited
Loading

google.auth is used in this repository and should be added as a direct dependency so that the minimum version can be stated and tested
https://github.com/search?q=repo%3Agoogleapis%2Fpython-bigquery%20google.auth&type=code

python-bigquery/setup.py

Lines 31 to 44 in 6249032

dependencies = [
# NOTE: Maintainers, please do not require google-api-core>=2.x.x
# Until this issue is closed
# https://github.com/googleapis/google-cloud-python/issues/10566
"google-api-core >= 1.31.5, <3.0.0dev,!=2.0.*,!=2.1.*,!=2.2.*,!=2.3.0",
# NOTE: Maintainers, please do not require google-cloud-core>=2.x.x
# Until this issue is closed
# https://github.com/googleapis/google-cloud-python/issues/10566
"google-cloud-core >= 1.6.0, <3.0.0dev",
"google-resumable-media >= 0.6.0, < 3.0dev",
"packaging >= 20.0.0",
"python-dateutil >= 2.7.2, <3.0dev",
"requests >= 2.21.0, < 3.0.0dev",
]

BEGIN_COMMIT_OVERRIDE
fix(deps): Require google-api-core>=1.34.1, >=2.11.0
fix: add google-auth as a direct dependency
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 6, 2024
@parthea parthea marked this pull request as ready for review February 6, 2024 02:20
@parthea parthea requested review from a team as code owners February 6, 2024 02:20
@parthea parthea requested a review from mrfaizal February 6, 2024 02:20
@chalmerlowe
Copy link
Collaborator

@parthea
Getting a dependency issue. From the traceback:

The conflict is caused by:
    google-cloud-bigquery 3.17.2 depends on google-auth<3.0.0dev and >=2.14.1
    google-api-core 1.31.5 depends on google-auth<2.0dev and >=1.25.0
    The user requested (constraint) google-auth==2.14.1

@chalmerlowe
Copy link
Collaborator

@parthea
What do you recommend here?
Loosen the restrictions on python-bigquery to accept a broader range of versions of google-auth OR submit a PR to google-api-core to broaden their range of acceptable versions?

This conflict is preventing us from closing this PR.

@parthea
Copy link
Contributor Author

parthea commented Feb 29, 2024

I think the minimum version of google-api-core should be bumped to 1.34.1 to match the version that we use for the generated clients.

https://github.com/googleapis/google-cloud-python/blob/24f085185f0c90cbb71fb68a3bdf45fac1a5fe5a/packages/google-cloud-access-approval/setup.py#L44

@chalmerlowe
Copy link
Collaborator

Most recent conflict errors that need resolution:

google-cloud-bigquery 3.17.2 depends on google-auth<3.0.0dev and >=2.14.1
google-api-core[grpc] 1.34.1 depends on google-auth<3.0dev and >=1.25.0
google-cloud-core 1.6.0 depends on google-auth<2.0dev and >=1.24.0
The user requested (constraint) google-auth==2.14.1

@kiraksi kiraksi mentioned this pull request Mar 6, 2024
Draft
4 tasks
@kiraksi
Copy link
Contributor

kiraksi commented Mar 6, 2024

@chalmerlowe This seems to be just a problem in python 3.7, which I believe we plan to deprecate for this library anyway no?

@chalmerlowe
Copy link
Collaborator

@chalmerlowe This seems to be just a problem in python 3.7, which I believe we plan to deprecate for this library anyway no?

Theoretically, yes. Deprecation plans are on hold for a bit. Will explain more in internal chat.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 8, 2024
chalmerlowe
chalmerlowe approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 713ce2c into main Mar 8, 2024
@chalmerlowe chalmerlowe deleted the parthea-patch-2 branch March 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@mrfaizal mrfaizal Awaiting requested review from mrfaizal mrfaizal is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @chalmerlowe @kiraksi @Linchin