Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot_ms to the Python QueryPlanEntry class #1828

Closed
kolban-google opened this issue Feb 25, 2024 · 1 comment · Fixed by #1831
Closed

Add slot_ms to the Python QueryPlanEntry class #1828

kolban-google opened this issue Feb 25, 2024 · 1 comment · Fixed by #1831
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kolban-google
Copy link

kolban-google commented Feb 25, 2024

Within our library, we have a class called QueryPlanEntry.. This class models the data found in a BigQuery Job (called ExplainQueryStage). The description of the BigQuery data can be found here. When we compare the fields, we are finding that there is an important one missing.

In ExplainQueryStage we have a field called "slotMs" which I take to be the slot milliseconds consumed by the given stage. When we look at the corresponding Python QueryPlanEntry, we do not find that field exposed as a property.

This issue asks for consideration for adding that property.

A quick examination makes me feel that the change might be made here.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 25, 2024
@Linchin
Copy link
Contributor

Linchin commented Feb 26, 2024

Thank you for catching this! I just added it in #1831 :)

@Linchin Linchin added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 26, 2024
@Linchin Linchin self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants