Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Due to upstream change in dataset, updates expected results #1761

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

chalmerlowe
Copy link
Contributor

A system test was failing because an upstream Google Public Dataset had changed slightly, which thus created a disparity between the expected results in the test and the actual results.
This PR corrects that error.

@chalmerlowe chalmerlowe requested review from a team as code owners January 4, 2024 17:21
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 4, 2024
@chalmerlowe chalmerlowe changed the title Due to upstream change in dataset, updates expected results fix: Due to upstream change in dataset, updates expected results Jan 4, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 5, 2024
@chalmerlowe chalmerlowe merged commit 132c14b into main Jan 5, 2024
22 checks passed
@chalmerlowe chalmerlowe deleted the update-expected-results branch January 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants