fix: AccessEntry API representation parsing #1682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding the
AccessEntry#_properties
with a deep copy of the API resource overwrites therole
property set inAccessEntry.__init__
which isn't present in the resource if therole
is set toNone
. This causesAccessEntry
s generated from API representations to no longer evaluate to equal with equivalentAccessEntry
resources instantiated throughAccessEntry.__init__
. The added unit test fails without the change and passes with the change.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1681 馃