Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter None values from OpenTelemetry attributes #1567

Merged
merged 4 commits into from
May 18, 2023
Merged

fix: filter None values from OpenTelemetry attributes #1567

merged 4 commits into from
May 18, 2023

Conversation

galz10
Copy link
Contributor

@galz10 galz10 commented May 16, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1385 🦕

@galz10 galz10 requested review from a team as code owners May 16, 2023 19:55
@galz10 galz10 requested a review from alvarowolfx May 16, 2023 19:55
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 16, 2023
@galz10 galz10 requested review from tswast and removed request for alvarowolfx May 16, 2023 19:56
@tswast tswast added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@tswast
Copy link
Contributor

tswast commented May 17, 2023

@galz10 If you look at the Kokoro output, there are some related failing tests that need to be investigated / fixed.

@galz10
Copy link
Contributor Author

galz10 commented May 18, 2023

@galz10 If you look at the Kokoro output, there are some related failing tests that need to be investigated / fixed.

Yea saw those, planning to fix those today

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 18, 2023
@galz10 galz10 merged commit 9ea2e21 into googleapis:main May 18, 2023
17 checks passed
@galz10 galz10 deleted the issue1385-fix branch May 18, 2023 17:52
@release-please release-please bot mentioned this pull request May 18, 2023
Merged
This was referenced Jun 13, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning on OpenTelemetry when some attributes are not set
3 participants
@galz10 @tswast @yoshi-kokoro