Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: raise most recent exception when not able to fetch query job after starting the job #1362

Merged
merged 6 commits into from
Jun 1, 2023
Merged

fix: raise most recent exception when not able to fetch query job after starting the job #1362

merged 6 commits into from
Jun 1, 2023

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 20, 2022

By raising the most recent exception, it's be clearer to customers and BigQuery backend engineers what the actual error is.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 247809965 🦕

@tswast tswast requested a review from a team September 20, 2022 20:05
@tswast tswast requested a review from a team as a code owner September 20, 2022 20:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 20, 2022
@tswast
Copy link
Contributor Author

tswast commented Sep 20, 2022

@aribray @chalmerlowe This PR needs some unit test updates to look for the changed exception type. Please contribute by adding commits to this PR (or fork this PR if you prefer)

@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@tswast
fix: raise most recent exception when not able to fetch query job aft…
ce7d358 
…er starting the job

Towards internal issue 247809965
@tswast tswast requested a review from a team as a code owner May 24, 2023 15:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 1, 2023
@tswast tswast requested review from chalmerlowe and removed request for Neenu1995 June 1, 2023 15:28
chalmerlowe
chalmerlowe approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 09cc1df into main Jun 1, 2023
18 checks passed
@chalmerlowe chalmerlowe deleted the tswast-b247809965 branch June 1, 2023 16:10
@release-please release-please bot mentioned this pull request Jun 1, 2023
Merged
This was referenced Jun 13, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tswast @chalmerlowe @yoshi-kokoro @aribray