Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Refactors code to account for a tdqm code deprecation #1357

Merged
merged 10 commits into from
Sep 19, 2022
Merged

Fix: Refactors code to account for a tdqm code deprecation #1357

merged 10 commits into from
Sep 19, 2022

Conversation

chalmerlowe
Copy link
Contributor

tqdm has changed elements of their codebase and issued a deprecation warning. This change implements several refactors to account for those changes and mitigate the deprecation warning.

The tdqm library would issue the following deprecation warning:

```Please use tqdm.notebook.tqdm instead of `tqdm.tqdm_notebook


This PR:

* revises our code and tests to point at the new file/function
* alters the import statements accordingly
* accounts for potential differences in warnings that appear when errors happen in the tests

Fixes #1146 🦕

@chalmerlowe chalmerlowe requested a review from a team September 15, 2022 21:33
@chalmerlowe chalmerlowe requested a review from a team as a code owner September 15, 2022 21:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 15, 2022
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@chalmerlowe chalmerlowe merged commit 1369a9d into main Sep 19, 2022
@chalmerlowe chalmerlowe deleted the fix-tdqm-code-deprecation branch September 19, 2022 21:18
@release-please release-please bot mentioned this pull request Sep 19, 2022
Merged
@chalmerlowe
Copy link
Contributor Author

Fixes #1146

This was referenced Oct 4, 2022
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@chalmerlowe @gcf-owl-bot @abdelmegahedgoogle
Fix: Refactors code to account for a tdqm code deprecation (googleapi…
055104f 
…s#1357)

* tests some options

* refactors to use tqdm.* notation

* refactors tqdm function calls to account for deprecation warning

* refactors _tqdm_helpers to account for tqdm deprecation warnings

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removes an extraneous reference to ipywidgets

* removes unneeded import

* removes import and fixes linting error

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chalmerlowe @dandhlee @yoshi-kokoro